Completed HW- Week2#14
Open
RollySeth wants to merge 1 commit intofrontend-application-development-uw20:masterfrom
Open
Completed HW- Week2#14RollySeth wants to merge 1 commit intofrontend-application-development-uw20:masterfrom
RollySeth wants to merge 1 commit intofrontend-application-development-uw20:masterfrom
Conversation
Author
|
Completed |
t1mwillis
reviewed
May 6, 2020
| function App() { | ||
| return ( | ||
| <div className="App"> | ||
| <table> |
t1mwillis
reviewed
May 6, 2020
| import Moment from 'moment'; | ||
|
|
||
| class AuthorInfo extends React.Component { | ||
| static propTypes= { |
t1mwillis
reviewed
May 6, 2020
| render(){ | ||
| return ( | ||
|
|
||
| <img style={{height: 30,width:30, borderRadius:50, marginLeft:3, marginRight:5, marginTop:3, marginBottom:5}} src={this.props.src} resizeMode={"cover"} alt="this is a blog post" /> |
t1mwillis
reviewed
May 6, 2020
|
|
||
| return ( | ||
|
|
||
| <div className="Blog-ForYou"> |
There was a problem hiding this comment.
typically classNames are lower case and dash separated blog-for-you, same with ids
t1mwillis
reviewed
May 6, 2020
| /> | ||
|
|
||
| {/* <td> | ||
| { yourArticlesList.author.isMediumMember === true ? |
There was a problem hiding this comment.
Try not to leave commented code in your completed assignment.
t1mwillis
reviewed
May 6, 2020
| @@ -0,0 +1,19 @@ | |||
| import React from 'react'; | |||
There was a problem hiding this comment.
This component is just a wrapper for a <img /> tag and you probably don't need it? 🤷
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Week 2 HW Submission
Please fill out the information below in order to complete your assignment. Feel free to update this comment later if necessary.